Skip to content

fix: Networking vpc_config AttributeError and telemetry region fallba…#5839

Open
aviruthen wants to merge 1 commit intoaws:masterfrom
aviruthen:fix/networking-vpc-config-and-region
Open

fix: Networking vpc_config AttributeError and telemetry region fallba…#5839
aviruthen wants to merge 1 commit intoaws:masterfrom
aviruthen:fix/networking-vpc-config-and-region

Conversation

@aviruthen
Copy link
Copy Markdown
Collaborator

Issue #, if available:

Fixes two bugs:

  1. AttributeError: 'Networking' object has no attribute 'vpc_config' — ModelBuilder._initialize_network_config() directly accesses self.network.vpc_config, but the Networking class (from sagemaker.core.training.configs) doesn't have that attribute. The else branch correctly handles Networking by reading subnets/security_group_ids directly, but execution never reaches it.
  2. Telemetry uses us-west-2 despite region override — The _telemetry_emitter decorator on @classmethod methods (like from_jumpstart_config) resolves args[0].sagemaker_session from the class descriptor (which is None), then falls back to a hardcoded us-west-2 default session. Customers with restricted network environments see timeouts on sts.us-west-2.amazonaws.com and sm-pysdk-t-us-west-2.s3.us-west-2.amazonaws.com.

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant